On Sat, Jan 29, 2022 at 09:53:25AM +0900, Michael Paquier wrote: > On Fri, Jan 28, 2022 at 06:27:29PM -0500, Andrew Dunstan wrote: >> I have committed this. But it will take time to get every buildfarm own >> to upgrade. > > Thanks for that.
So, it took me some time to get back to this thread, and looked at it for the last couple of days... The buildfarm client v14 has been released on the 29th of January, which means that we are good to go. I have found one issue while reviewing things: the creation of the new subdirectory and its contents should satisfy group permissions for the new cluster's data folder, but we were not doing that properly as we called GetDataDirectoryCreatePerm() after make_outputdirs() so we missed the proper values for create_mode and umask(). The rest looked fine, and I got a green CI run on my own repo. Hence, applied. I'll keep an eye on the buildfarm, in case. -- Michael
signature.asc
Description: PGP signature
