On Tue, Feb 1, 2022 at 9:10 AM Fujii Masao <masao.fu...@oss.nttdata.com> wrote: > The order of arguments for LSN seems wrong. > LSN_FORMAT_ARGS(ControlFile->checkPoint) should be specified ahead of > LSN_FORMAT_ARGS(ControlFile->checkPointCopy.redo)?
Thanks. Corrected. > Could you tell me why the information for LSN is reported earlierly in the > log message? Since ordinally users would be more interested in the > information about I/O by checkpoint, the information for LSN should be placed > later? Sorry if this was already discussed. It is useful (for debugging purposes) if the checkpoint end message has the checkpoint LSN(end) and REDO LSN(start). It gives more context while analyzing checkpoint-related issues. The pg_controldata gives the last checkpoint LSN and REDO LSN, but having this info alongside the log message helps analyze issues that happened previously, connect the dots and identify the root cause. Regards, Bharath Rupireddy.
v7-0001-Add-checkpoint-and-redo-LSN-to-LogCheckpointEnd-l.patch
Description: Binary data
v7-0002-Change-location-to-lsn-in-pg_controldata.patch
Description: Binary data
