At Thu, 27 Jan 2022 15:31:37 +0900, Michael Paquier <mich...@paquier.xyz> wrote in > On Thu, Jan 20, 2022 at 12:13:08PM +0530, Amul Sul wrote: > > I found the cause for the test failing on window -- is due to the > > custom archive command setting which wasn't setting the correct window > > archive directory path. > > After reading this patch and this thread, I have noticed that you are > testing the same thing as Heikki here, patch 0001: > https://www.postgresql.org/message-id/52bc9ccd-8591-431b-0086-15d9acf25...@iki.fi > > The patch sent on the other thread has a better description and shape, > so perhaps we'd better drop what is posted here in favor of the other > version. Thoughts?
pg_switch_wal() is more preferable than filling-in a large number of records as the means to advance segments because it is stable against changes of wal_segment_size. As you said, using has_restoring on initializing node_ptr is simpler than explicitly setting archive_dir from that of another node. regards. -- Kyotaro Horiguchi NTT Open Source Software Center