On Tue, Apr 3, 2018 at 7:13 PM, Andres Freund <and...@anarazel.de> wrote:
> On 2018-04-03 11:52:26 +0000, Magnus Hagander wrote: > > Validate page level checksums in base backups > > > > When base backups are run over the replication protocol (for example > > using pg_basebackup), verify the checksums of all data blocks if > > checksums are enabled. If checksum failures are encountered, log them > > as warnings but don't abort the backup. > > > > This becomes the default behaviour in pg_basebackup (provided checksums > > are enabled on the server), so add a switch (-k) to disable the checks > > if necessary. > > > > Author: Michael Banck > > Reviewed-By: Magnus Hagander, David Steele > > Discussion: https://postgr.es/m/20180228180856.GE13784@ > nighthawk.caipicrew.dd-dns.de > > Hm, something isn't quite right with the test: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm= > pogona&dt=2018-04-03%2016%3A10%3A01 > > # WARNING: 6 total checksum verification failures > # pg_basebackup: checksum error occured > # ' > # doesn't match '(?^s:^WARNING.*7 total checksum verification > failures)' > Yeah, there's clearly a second problem here. I'm stuck in meetings most of tonight, so I might not get to it right away. If someonen else figures it out meanwhile please do, otherwise I'll get to it as soon as I can. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
