On Tue, Apr 3, 2018 at 4:32 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > I wrote: > > Magnus Hagander <mag...@hagander.net> writes: > >> Unless.. %ld is the wrong thing to print: > >> static int64 total_checksum_failures; > >> We should perhaps be using something other than %ld to print that? > > > INT64_FORMAT. > > BTW, don't just stick INT64_FORMAT into the message-to-be-translated, > or you'll break things for translation. Good practice is to sprintf > into a local char array with INT64_FORMAT, then include the number > into the displayed message with %s. You can find examples easily > by grepping for INT64_FORMAT. >
Thanks for the hint. I've pushed a fix along this line, let's see if clears things. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>