On Fri, Jan 21, 2022 at 2:56 PM Greg Nancarrow <gregn4...@gmail.com> wrote: > > On Thu, Jan 20, 2022 at 12:12 PM houzj.f...@fujitsu.com > <houzj.f...@fujitsu.com> wrote: > > (3) pgoutput_row_filter_exec_expr > pgoutput_row_filter_exec_expr() returns false if "isnull" is true, > otherwise (if "isnull" is false) returns the value of "ret" > (true/false). > So the following elog needs to be changed (Peter Smith previously > pointed this out, but it didn't get completely changed): > > BEFORE: > + elog(DEBUG3, "row filter evaluates to %s (isnull: %s)", > + DatumGetBool(ret) ? "true" : "false", > + isnull ? "true" : "false"); > AFTER: > + elog(DEBUG3, "row filter evaluates to %s (isnull: %s)", > + isnull ? "false" : DatumGetBool(ret) ? "true" : "false", > + isnull ? "true" : "false"); >
Do you see any problem with the current? I find the current one easy to understand. -- With Regards, Amit Kapila.
