On 04/03/2018 04:07 PM, Stas Kelvich wrote: > > >> On 3 Apr 2018, at 16:56, Tomas Vondra <tomas.von...@2ndquadrant.com> wrote: >> >> >> So I think we need a subscription parameter to enable/disable this, >> defaulting to 'disabled’. > > +1 > > Also, current value for LOGICALREP_IS_COMMIT is 1, but previous code expected > flags to be zero, so this way logical replication between postgres-10 and > postgres-with-2pc-decoding will be broken. So ISTM it’s better to set > LOGICALREP_IS_COMMIT to zero and change flags checking rules to accommodate > that. >
Yes, that is a good point actually - we need to test that replication between PG10 and PG11 works correctly, i.e. that the protocol version is correctly negotiated, and features are disabled/enabled accordingly etc. regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
