On 1/23/22 16:31, Andres Freund wrote: >> The most common issues we get are around this issue of virtualized paths >> in the TAP tests. If people followed the rule I suggested upthread, 99% >> of those problems would go away. I realize it's annoying - I've been >> caught by it myself on more than one occasion. Maybe there's a way to >> avoid it, but if there is I'm unaware of it. But I don't think it's in >> any way a good reason to drop msys support. > Needing to sprinkle perl2host and MSYS2_ARG_CONV_EXCL over a good number of > tests, getting weird errors when failing, etc IMO isn't a scalable approach, > for a platform that most of use never use. > > Can't we solve this in a generic way? E.g. by insisting that the test run with > a native perl and normalizing the few virtual paths we get invoked with > centrally? Making the msys initial setup a bit more cumbersome would IMO be > an OK price to pay for making it maintainable / predictable from other > platforms, as long as we have some decent docs and decent error messages. >
Nice idea. I have a suspicion that it's going to be harder than you think, but I'll be very happy to be proved wrong. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
