On Thu, Jan 20, 2022 at 9:18 PM Michael Paquier <mich...@paquier.xyz> wrote: > On Thu, Jan 20, 2022 at 10:25:43AM -0500, Robert Haas wrote: > > You don't need to test for gzip and none in two places each. Just make > > the block with the "It does not match ..." comment the "else" clause > > for this last part. > > Indeed, that looks better. I have done an extra pass on this stuff > this morning, and applied it, so we should be done here.
Thanks. One thing I just noticed is that the enum we're using here is called WalCompressionMethod. But we're not compressing WAL. We're compressing tarfiles of the data directory. -- Robert Haas EDB: http://www.enterprisedb.com
