Thanks for the review. On Tue, Dec 21, 2021 at 5:54 PM Zhihong Yu <z...@yugabyte.com> wrote: > Hi, > > + int lockflags = 0; > + TM_Result test; > + > + lockflags = TUPLE_LOCK_FLAG_LOCK_UPDATE_IN_PROGRESS; > > The above assignment can be meged with the line where variable lockflags is > declared.
Sure. > + GetUserIdAndSecContext(&save_userid, &save_sec_context); > > save_userid -> saved_userid > save_sec_context -> saved_sec_context I agree that's better though I guess I had kept the names as they were in other functions. Fixed nevertheless. > + * the transaction-snapshot mode. If we didn't push one already, do > > didn't push -> haven't pushed Done. > For ri_PerformCheck(): > > + bool source_is_pk = true; > > It seems the value of source_is_pk doesn't change - the value true can be > plugged into ri_ExtractValues() calls directly. OK, done. v13 is attached. -- Amit Langote EDB: http://www.enterprisedb.com
v13-0002-Avoid-using-SPI-for-some-RI-checks.patch
Description: Binary data
v13-0001-Add-isolation-tests-for-snapshot-behavior-in-ri_.patch
Description: Binary data
