Here are my review comments for v64-0001 (review of updates since v63-0001)
~~~ 1. doc/src/sgml/ref/create_publication.sgml - typo? + The <literal>WHERE</literal> clause allows simple expressions that don't have + user-defined functions, operators, non-immutable built-in functions. + </para> + I think there is a missing "or" after that Oxford comma. e.g. BEFORE "... operators, non-immutable built-in functions." AFTER "... operators, or non-immutable built-in functions." ~~ 2. commit message - typo You said that the above text (review comment 1) came from the 0001 commit message, so please make the same fix to the commit message. ~~ 3. src/backend/replication/logical/tablesync.c - redundant trailing ";" + /* Check for row filters. */ + resetStringInfo(&cmd); + appendStringInfo(&cmd, + "SELECT DISTINCT pg_get_expr(pr.prqual, pr.prrelid)" + " FROM pg_publication p" + " LEFT OUTER JOIN pg_publication_rel pr" + " ON (p.oid = pr.prpubid AND pr.prrelid = %u)," + " LATERAL pg_get_publication_tables(p.pubname) GPT" + " WHERE GPT.relid = %u" + " AND p.pubname IN ( %s );", + lrel->remoteid, + lrel->remoteid, + pub_names.data); I think that trailing ";" of the SQL is not needed, and nearby SQL execution code does not include one so maybe better to remove it for consistency. ------ Kind Regards, Peter Smith. Fujitsu Australia
