Re: [PATCH]Add tab completion for foreigh table

[Fujii Masao]

On 2022/01/11 21:43, tanghy.f...@fujitsu.com wrote:

Hi

Attached a patch to improve the tab completion for foreigh table.

Thanks!

Isn't it better to tab-complete not only "PARTITION OF" but also "(" for CREATE 
FOREIGN TABLE?

Also modified some DOC description of ALTER TABLE at [1] in according with 
CREATE INDEX at [2].

In [1], we use "ALTER INDEX ATTACH PARTITION"
In [2], we use "ALTER INDEX ... ATTACH PARTITION"

I think the format in [2] is better.

Agreed.

IMO it's better to make the docs changes in separate patch because they are not 
directly related to the improvement of tab-completion.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION