(We had better avoid top-posting[1])
On Tue, Jan 11, 2022 at 10:01 AM Imseih (AWS), Sami <sims...@amazon.com> wrote: > > I agree, Renaming "index_vacuum_count" can be taken up in a separate > discussion. > > I have attached the 3rd revision of the patch which also includes the > documentation changes. Also attached is a rendered html of the docs for > review. Thank you for updating the patch! Regarding the new pg_stat_progress_vacuum_index view, why do we need to have a separate view? Users will have to check two views. If this view is expected to be used together with and joined to pg_stat_progress_vacuum, why don't we provide one view that has full information from the beginning? Especially, I think it's not useful that the total number of indexes to vacuum (num_indexes_to_vacuum column) and the current number of indexes that have been vacuumed (index_ordinal_position column) are shown in separate views. Also, I’m not sure how useful index_tuples_removed is; what can we infer from this value (without a total number)? Regards, [1] https://en.wikipedia.org/wiki/Posting_style#Top-posting -- Masahiko Sawada EDB: https://www.enterprisedb.com/
