On Tue, Jan 11, 2022 at 02:03:07PM -0600, Justin Pryzby wrote: > I added mkdir() before the other stuff that messes with logfiles, because it > needs to happen before that. > > Are you suggesting to change the pre-existing behavior of when logfiles are > created, like 0002 ?
Yes, something like that. > There's no reason not to. We created the dir, and the user didn't specify to > preserve it. It'd be their fault if they put something valuable there after > starting pg_upgrade. This is a path for the data internal to pg_upgrade. My take is that the code simplifications the new option brings are more valuable than this assumption, which I guess would unlikely happen. I may be wrong, of course. By the way, while thinking about that, should we worry about --logdir="."? -- Michael
signature.asc
Description: PGP signature