> On 2 April 2018 at 11:27, Arthur Zakirov <a.zaki...@postgrespro.ru> wrote: > On Mon, Apr 02, 2018 at 11:41:12AM +0300, Oleg Bartunov wrote: >> On Mon, Apr 2, 2018 at 9:45 AM, Arthur Zakirov <a.zaki...@postgrespro.ru> >> wrote: >> I found this bug, when working on presentation about FTS and it looked >> annoying, since it validates >> the consistency of FTS.I think this is a bug, which needs to be fixed, >> else inconsistency with existing full text search will be gets >> deeper. >> >> The fix looks trivial, but needs a review, of course. > > Oh, I understood. The code looks good, tests passed. But maybe it is > better to use NumericGetDatum() instead of PointerGetDatum()?
Well, technically speaking they're the same, but yes, NumericGetDatum would be more precise. I've modified it in the attached patch.
jsonb_to_tsvector_numeric_v2.patch
Description: Binary data