On 1/5/22 02:32, Michael Paquier wrote: > On Sun, Jan 02, 2022 at 01:34:45PM -0800, Andres Freund wrote: >> The tests don't seem to pass on windows: >> https://cirrus-ci.com/task/5412456754315264?logs=test_bin#L47 >> https://api.cirrus-ci.com/v1/artifact/task/5412456754315264/tap/src/bin/pg_ctl/tmp_check/log/regress_log_004_logrotate >> >> psql:<stdin>:1: ERROR: division by zero >> could not open >> "c:/cirrus/src/bin/pg_ctl/tmp_check/t_004_logrotate_primary_data/pgdata/current_logfiles": >> The system cannot find the file specified at t/004_logrotate.pl line 87. > This seems to point out that the syslogger is too slow to capture the > logrotate signal, and the patch set is introducing nothing new in > terms of infrastructure, just an extra value for log_destination. > This stuff passes here, and I am not spotting something amiss after an > extra close read. > > Attached is an updated patch set that increases the test timeout (5min > -> 10min). That should help, I assume.
ITYM 3 min -> 6 min. But in any case, is that really going to solve this? The file should exist, even if its contents are not up to date, AIUI. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
