On Wed, Jan 5, 2022 at 9:52 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > ...
> Another minor comment: > +static bool pgoutput_row_filter(enum ReorderBufferChangeType changetype, > > Do we need to specify the 'enum' type before changetype parameter? > That is because there is currently no typedef for the enum ReorderBufferChangeType. Of course, it is easy to add a typedef and then this 'enum' is not needed in the signature, but I wasn't sure if adding a new typedef strictly belonged as part of this Row-Filter patch or not. ------ Kind Regards. Peter Smith. Fujitsu Australia.
