On Thu, Dec 30, 2021 at 3:30 AM Justin Pryzby <pry...@telsasoft.com> wrote: > > On Mon, Dec 20, 2021 at 11:18:41AM +1100, Peter Smith wrote: > > For some reason the current HEAD PublicationActions is a struct of > > boolean representing combinations of the 4 different "publication > > actions". > > > > I felt it is more natural to implement boolean flag combinations using > > a bitmask instead of a struct of bools. IMO using the bitmask also > > simplifies assignment and checking of said flags. > > Peter E made a suggestion to use a similar struct with bools last year for > REINDEX. > https://www.postgresql.org/message-id/7ec67c56-2377-cd05-51a0-691104404...@enterprisedb.com > > Alvaro pointed out that the integer flags are better for ABI compatibility - > it > would allow adding a new flag in backbranches, if that were needed for a > bugfix. > > But that's not very compelling, since the bools have existed in v10... > Also, the booleans directly correspond with the catalog. > > + if (pubform->pubinsert) pub->pubactions |= PUBACTION_INSERT; > > This is usually written like: > > pub->pubactions |= (pubform->pubinsert ? PUBACTION_INSERT : 0) >
Thanks for the info, I've modified those assignment styles as suggested. ------ Kind Regards, Peter Smith. Fujitsu Australia.
v3-0001-PublicationActions-use-bit-flags.patch
Description: Binary data
