On Fri, Mar 30, 2018 at 8:10 PM, CharSyam <chars...@gmail.com> wrote: > Hi, I found some missing check for windows int init_slot function in > vacuumdb.c > > in windows > SOCKET is unsigned type. so > > slot->sock < 0 never can be under 0. > > so this patch just check using slot->sock == PGINVALID_SOCKET >
- if (slot->sock < 0) + if (slot->sock == PGINVALID_SOCKET || slot->sock < 0) If you are checking for PGINVALID_SOCKET, why do you need the second part of check (slot->sock < 0)? -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
