On 24.11.21 05:20, Michael Paquier wrote:
On Mon, Nov 22, 2021 at 11:21:52AM +0100, Peter Eisentraut wrote:
On 19.11.21 08:31, Michael Paquier wrote:
Regarding 0001, I find the existing code a bit more self-documenting
if we keep those checks flagInhAttrs() and guessConstraintInheritance().
So I would rather leave these.
In that case, the existing check in guessConstraintInheritance() seems
wrong, because it doesn't check for RELKIND_MATVIEW. Should we fix that?
It's dead code either way, but if the code isn't exercises, then these kinds
of inconsistency come about.
Yeah, this one could be added. Perhaps that comes down to one's taste
at the end, but I would add it.
Ok, I have committed adding the missing relkind, as you suggest. Patch
v3-0001 is therefore obsolete.
