On 25.11.21 16:46, Zhihong Yu wrote:
For patch 3,

+int64
+pg_strtoint64(const char *s)

How about naming the above function pg_scanint64()?
pg_strtoint64xx() can be namedĀ pg_strtoint64() - this would align with existing function:

pg_strtouint64(const char *str, char **endptr, int base)

That would be one way. But the existing pg_strtointNN() functions are pretty widely used, so I would tend toward finding another name for the less used pg_strtouint64(), maybe pg_strtouint64x() ("extended").



Reply via email to