On Wed, Dec 1, 2021 at 6:45 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > > Justin Pryzby <pry...@telsasoft.com> writes: > > +1 to document it, but it seems like the worse problem is allowing the > > admin to > > write a configuration which causes the server to fail to start, without > > having > > issued a warning. > > > I think you could fix that with a GUC check hook to emit a warning. > > I'm not sure what objections people might have to this. Maybe it's > > confusing > > to execute preliminary verification of the library by calling stat() but > > not do > > stronger verification for other reasons the library might fail to load. > > Like > > it doesn't have the right magic number, or it's built for the wrong server > > version. Should factor out the logic from internal_load_library and check > > those too ? > > Considering the vanishingly small number of actual complaints we've > seen about this, that sounds ridiculously over-engineered. > A documentation example should be sufficient.
Thanks. Here's the v1 patch adding examples in the documentation. Regards, Bharath Rupireddy.
v1-0001-document-examples-of-setting-up-multiple-values-f.patch
Description: Binary data
