On Wednesday, December 1, 2021 1:23 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Wed, Dec 1, 2021 at 1:00 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Wed, Dec 1, 2021 at 9:12 AM Masahiko Sawada <sawada.m...@gmail.com> > > wrote: > > > If so, the result from the second check_sql is unstable and it's > > > probably better to check the result only once. That is, the first > > > check_sql includes the command and we exit from the function once we > > > confirm the error entry is expectedly updated. > > > > > > > Yeah, I think that should be fine. > > Okay, I've attached an updated patch. Please review it. >
I agreed that checking the result only once makes the test more stable. The patch looks good to me. Best regards, Hou zj