On Mon, Nov 29, 2021 at 11:27 AM Tom Lane <t...@sss.pgh.pa.us> wrote: > > We've been burnt by this issue repeatedly (cf c2d1eea9e, d025cf88b, > 11b500072) so I think it's time to try to formalize and document > what to do to export a variable from src/common/ or src/port/.
+1 to document it. > Here's a draft patch. I'm not in love with the name "PGDLLIMPORT_FE" > and would welcome better ideas. How about PGDLLIMPORT_FE_BE which represents the macro to be used for variables/functions common to both frontend and backend? Otherwise, PGDLLIMPORT_COMM/PGDLLIMPORT_COMMON or PGDLLIMPORT_2 or PGDLLIMPORT_PORT? We have some of the #defines with "FeBe": /* * prototypes for functions in pqcomm.c */ extern WaitEventSet *FeBeWaitSet; #define FeBeWaitSetSocketPos 0 #define FeBeWaitSetLatchPos 1 Regards, Bharath Rupireddy.
