On Wed, Nov 24, 2021 at 9:40 PM Japin Li <japi...@hotmail.com> wrote: > > > On Wed, 24 Nov 2021 at 23:59, Bharath Rupireddy > <bharath.rupireddyforpostg...@gmail.com> wrote: > > On Wed, Nov 24, 2021 at 9:09 PM Bharath Rupireddy > >> > Thoughts? > >> > >> Attaching the rebased v2 patch. > > > > On windows the previous patches were failing, fixed that in the v3 > > patch. I'm really sorry for the noise. > > > > Cool! When I try to use it, there is an error for -v, --verbose option. > > px@ubuntu:~/Codes/postgres/Debug$ pg_replslotdata -v > pg_replslotdata: invalid option -- 'v' > Try "pg_replslotdata --help" for more information. > > This is because the getopt_long() missing 'v' in the third parameter. > > while ((c = getopt_long(argc, argv, "D:v", long_options, NULL)) != -1)
Thanks for taking a look at the patch, attaching v4. There are many things that I could do in the patch, for instance, more comments, documentation, code improvements etc. I would like to first know what hackers think about this tool, and then start spending more time on it. Regards, Bharath Rupireddy.
v4-0001-pg_replslotdata.patch
Description: Binary data