Justin Pryzby <pry...@telsasoft.com> writes:
> On Wed, Nov 17, 2021 at 03:59:59PM -0300, Euler Taveira wrote:
>> I took a look at this patch. I have a few comments.
>>
>> + ereport(WARNING,
>> + (errmsg("signalling postmaster with PID %d is not allowed", pid)));
>>
>> I would say "signal postmaster PID 1234 is not allowed". It is not an
>> in-progress action.
> It's correct to say "signalling ... is not allowed", which means the same as
> "it is not allowed to signal ...".
Yeah, the grammar is fine as far as that goes. What reads awkwardly to me
is inclusion of "with PID %d" in the middle of the sentence. That seems
odd, not least because it leaves the impression that maybe it would've
been okay to signal some other postmaster with a different PID.
Frankly, I think the existing wording is fine and this patch adds
complication without making any useful improvement. We could maybe change
"is not a PostgresSQL server process" to "is not a PostgresSQL backend
process", but I wouldn't go further than that.
regards, tom lane
