Thanks for updating the patch :)

> Currently, DBAs need the table name to see the constraint information.

Or, they can query pg_constraint or information_schema: check_constraints,
table_constraints.

> -                             success = listConversions(pattern, 
> show_verbose, show_system);
> +                             if (strncmp(cmd, "dco", 3) == 0) /* Constraint 
> */
> +                                     switch (cmd[3])
> +                                     {
> +                                             case '\0':
> +                                             case '+':

Does "+" do anything ?

> +++ b/src/bin/psql/help.c
> @@ -231,6 +231,7 @@ slashUsage(unsigned short int pager)

>       fprintf(output, _("  \\db[+]  [PATTERN]      list tablespaces\n"));
>       fprintf(output, _("  \\dc[S+] [PATTERN]      list conversions\n"));
> +     fprintf(output, _("  \\dco[S] [PATTERN]      list constraint\n"));

Should be plural "constraints".

I think "exclude" should be called "exclusion" ("exclude" sounded to me like
you're going to provide a way to "exclude" types of constraints, like "xc"
would show everything except check constraints).

-- 
Justin


Reply via email to