Hi, Thank you for your comment. The attached patch stops message splitting. This patch also limits the timing of message output when huge_pages = try and HugePages is not used.
Regards, Noriyoshi Shinoda -----Original Message----- From: Justin Pryzby [mailto:pry...@telsasoft.com] Sent: Friday, October 22, 2021 11:38 AM To: Shinoda, Noriyoshi (PN Japan FSIP) <noriyoshi.shin...@hpe.com> Cc: masao.fu...@oss.nttdata.com; pgsql-hack...@postgresql.org; rjuju...@gmail.com; t...@sss.pgh.pa.us; Kyotaro Horiguchi <horikyota....@gmail.com> Subject: Re: Improve logging when using Huge Pages + ereport(LOG, (errmsg("Anonymous shared memory was + allocated %s huge pages.", with_hugepages ? "with" : "without"))); You shouldn't break a sentence into pieces like this, since it breaks translation. You don't want an untranslated "without" to appear in the middle of the translated message. There are cases where a component *shouldn't* be translated, like this one: where "numeric" should not be translated. src/backend/utils/adt/numeric.c: errmsg("invalid input syntax for type %s: \"%s\"", src/backend/utils/adt/numeric.c- "numeric", str))); -- Justin
huge_pages_log_v7.diff
Description: huge_pages_log_v7.diff
