Hi, On 2021-10-26 13:51:55 -0400, Tom Lane wrote: > Mark Dilger <mark.dil...@enterprisedb.com> writes: > > It appears fmtint only has three options for base, being 10, 16, and 8. > > Have you profiled with either of the others special cased as well? I don't > > see much use in optimizing for octal, but hexadecimal is used quite a bit > > in wal with patterns like "%08X%08X%08X". > > I'd be inclined to just hard-wire the three allowed cases, and not have > an arbitrary-divisor code path at all.
Yea, I came to the same conclusion. But I'd implement it by moving the division into a separate inline function called from the switch. I tested that locally and it works, but I got sidetracked by [1]. Greetings, Andres Freund [1] https://postgr.es/m/20211026180454.xcjmu3kwmn3tka57%40alap3.anarazel.de
