Japin Li <japi...@hotmail.com> writes:
> Attach v5 patch. This patch set the datestyle, intervalstyle and
> extra_float_digits parameters when we connect to publisher, this can
> avoid the network round trips (compare with the first patch).
You could make it a little less confusing by not insisting on a
space in the datestyle. This should work fine:
vals[i] = "-c datestyle=ISO,YMD -c intervalstyle=postgres
extra_float_digits=3";
Also, I think some comments would be appropriate.
I don't see any value whatsoever in the more complicated version
of the patch. It's just more code to maintain and more things
to go wrong. And not only at our level, but the DBA's too.
What if the subscriber and publisher are of different PG versions
and have different ideas of the valid values of these settings?
regards, tom lane
