On 2021-Oct-20, Robert Haas wrote: > On Tue, Oct 19, 2021 at 7:30 PM Alvaro Herrera <alvhe...@alvh.no-ip.org> > wrote: > > Hah. Yeah, when you can do things like that and the tests don't break, > > that indicates a problem in the tests. > > I *think* the problem is actually in the code, not the tests. In other > words, from what I can tell, we copy the bogus timeline value (0, or a > random number) into several places, but then eventually overwrite all > copies of that value with a correct value before using it for > anything. So in other words I think that the comment saying that this > code is initializing values that WalSndSegmentOpen is going to need is > just wrong. I don't completely understand why it's wrong, but I think > it IS wrong.
Oh, I'm not saying that there isn't a problem in the code. I'm just saying that there is *also* a problem (an omission) in the tests. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "Cómo ponemos nuestros dedos en la arcilla del otro. Eso es la amistad; jugar al alfarero y ver qué formas se pueden sacar del otro" (C. Halloway en La Feria de las Tinieblas, R. Bradbury)
