On 10/18/21, 12:47 AM, "Michael Paquier" <mich...@paquier.xyz> wrote: > I have reviewed the last patch posted upthread, and while testing > partitioned indexes I have noticed that we don't need to do a custom > check as part of ATExecSetOptions(), because we have already that in > ATSimplePermissions() with details on the relkind failing. This makes > the patch simpler, with a better error message generated. I have > added a case for partitioned indexes while on it.
Ah, yes, that is much better. > Attached is the patch I am finishing with, that should go down to > v13 (this is going to conflict on REL_13_STABLE, for sure). +DROP INDEX btree_tall_tbl_idx2; +ERROR: index "btree_tall_tbl_idx2" does not exist I think this is supposed to be "btree_tall_idx2". Otherwise, the patch looks reasonable to me. Nathan
