On 10/9/21, 2:12 AM, "Bharath Rupireddy" <bharath.rupireddyforpostg...@gmail.com> wrote: > Here's the v1, please review it further.
Thanks for the patch. - /* Only allow superusers to log memory contexts. */ - if (!superuser()) + /* + * Only superusers or members of pg_read_all_stats can log memory contexts. + */ + if (!is_member_of_role(GetUserId(), ROLE_PG_READ_ALL_STATS)) I personally think pg_log_backend_memory_contexts() should remain restricted to superusers since it directly impacts the server log. However, if we really did want to open it up to others, couldn't we add GRANT/REVOKE statements in system_functions.sql and remove the hard-coded superuser check? I think that provides a bit more flexibility (e.g., permission to execute it can be granted to others without giving them pg_read_all_stats). Nathan
