On Mon, Oct 11, 2021 at 2:41 PM Mark Dilger <mark.dil...@enterprisedb.com> wrote: > > Overall, your approach looks good to me. Will Robert take care of > > committing this, or should I? > > I'd appreciate if you could fix up the <warning> in the docs and do the > commit.
Cool. I pushed just the amcheck changes a moment ago. I attach the remaining changes from your v3, with a new draft commit message (no real changes). I didn't push the rest (what remains in the attached revision) just yet because I'm not quite sure about the approach used to exclude temp tables. Do we really need the redundancy between prepare_btree_command(), prepare_heap_command(), and compile_relation_list_one_db()? All three exclude temp relations, plus you have extra stuff in prepare_btree_command(). There is some theoretical value in delaying the index specific stuff until the query actually runs, at least in theory. But it also seems unlikely to make any appreciable difference to the overall level of coverage in practice. Would it be simpler to do it all together, in compile_relation_list_one_db()? Were you concerned about things changing when parallel workers are run? Or something else? Many thanks -- Peter Geoghegan
v4-0001-pg_amcheck-avoid-unhelpful-verification-attempts.patch
Description: Binary data
