On Mon, Oct 4, 2021 at 2:51 PM Dilip Kumar <dilipbal...@gmail.com> wrote:

I have implemented the patch with approach2 as well, i.e. instead of
scanning the pg-class, we scan the directory.

IMHO, we have already discussed most of the advantages and
disadvantages of both approaches so I don't want to mention those
again. But I have noticed one more issue with the approach2,
basically, if we scan the directory then we don't have any way to
identify the relation-OID and that is required in order to acquire the
relation lock before copying it, right?

Patch details:
0001 to 0006 implements an approach1
0007 removes the code of pg_class scanning and adds the directory scan.


-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Attachment: v5-0001-Refactor-relmap-load-and-relmap-write-functions.patch
Description: Binary data

Attachment: v5-0003-Refactor-index_copy_data.patch
Description: Binary data

Attachment: v5-0004-Extend-bufmgr-interfaces.patch
Description: Binary data

Attachment: v5-0005-New-interface-to-lock-relation-id.patch
Description: Binary data

Attachment: v5-0002-Extend-relmap-interfaces.patch
Description: Binary data

Attachment: v5-0006-WAL-logged-CREATE-DATABASE.patch
Description: Binary data

Attachment: v5-0007-POC-WAL-LOG-CREATE-DATABASE-APPROACH-2.patch
Description: Binary data

Reply via email to