On 24 March 2018 at 16:42, David Rowley <david.row...@2ndquadrant.com> wrote: > I've done this in the attached patch against v39. > > I also renamed argvalues to argexprs, since they're not values. The > PartClauseInfo could probably do with the same change too, but I > didn't touch it.
The attached goes a little further and does a bit more renaming. I don't think "values" is a good name for a list of Exprs. I'd expect that might be a better-suited name for an array of Datums. I've also added and modified a few comments. More comments are still required. The Step structs are mostly undocumented still, but I'm trying to understand how all this fits together still, at least well enough to write about it. The attached delta applies on top of v39 plus delta1. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
v39_drowley_delta2.patch
Description: Binary data
