On 03/05/2018 08:57 PM, Alvaro Herrera wrote: > Tomas Vondra wrote: > >> 4) I see you've added generateClonedExtStatsStmt to parse_utilcmd.h, but >> it was only really called in parse_utilcmd.c, so I've made it static. I >> don't think we need to expose stuff unnecessarily. > >> BTW the last point made me thinking, because parse_utilcmd.h also >> exposes generateClonedIndexStmt. That is however necessary, because it's >> called from DefineRelation when copying indexes from partitioned table >> to partitions. I'm wondering - shouldn't we do the same thing for >> extended statistics? > > Maybe, but that would not be a bugfix anymore. So if we do want that, > that is definitely a new feature, so it should be its own patch; the > copying of indexes to partitions is a new feature in pg11. >
Sure, I wasn't really suggesting squashing that into this bugfix. -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
