Hello David,
On 05.03.2018 18:50, David Steele wrote:
Hello Maksim,
On 1/27/18 2:19 PM, Arthur Zakirov wrote:
Is there actual need in UnregisterCustomProcSignal() within _PG_init()?
An extension registers a handler and then unregister it doing
nothing. It seems useless.
Also process_shared_preload_libraries_in_progress within _PG_fini() will
be false I think. _PG_fini() won't be called though, because
implementation of internal_unload_library() is disabled.
Actually, is there need in UnregisterCustomProcSignal() at all? It
unregisters a handler only in current backend, for actual unergistering
we need to call it everywhere, if I'm not mistaken.
This patch has been in Waiting on Author state for almost three weeks.
Have you had a chance to consider Arthur's suggestions?
Yes, I want to rework my patch to enable setup of custom signals on
working backend without preload initialization.
Do you know when you'll have an updated patch available?
I want to actuate the work on this patch for the next 12 release. Sorry,
for now I can not keep up with the current release.
--
Regards,
Maksim Milyutin
