On Thu, Mar 1, 2018 at 3:03 AM, Andres Freund <and...@anarazel.de> wrote: > - amcheck heap verification > > NR. Been submitted for a while, a modicum of code review has been > performed. > > Adds a fair bit of code: > 21 files changed, 1032 insertions(+), 64 deletions(-) > > but is low risk, being a readonly contrib module. > > Can probably committed if somebody has the energy.
A lot of that code is boilerplate test harness code. If you actually look at the changes to amcheck, there are only a couple of hundred lines of code, many of which are comments (there is also another 300 lines for the Bloom filter implementation). The changes to the IndexBuildHeapScan() interface made by parallel CREATE INDEX allowed me to simplify things considerably in the most recent revision. -- Peter Geoghegan
