On Tue, Feb 6, 2018 at 4:56 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote:
> For vacuuming fsm of index, we might have to consider to
> vacuum fsm of index after lazy_vacuum_index.
I've been thinking about that, and I think you're right.
So here's a fourth patch that adds that to nbtree's bulkdelete implementation.
Seems to be the best place to add such a thing.
GIN and GIST don't delete pages until vacuumcleanup, so they can't do
the same, sadly.
From 505f3143f85d42cea5adf6f04332443a61edcac0 Mon Sep 17 00:00:00 2001
From: Claudio Freire <klaussfre...@gmail.com>
Date: Tue, 27 Feb 2018 12:51:46 -0300
Subject: [PATCH] Index vacuum: Vacuum FSM after each bulkdelete call
If any pages have been deleted during bulkdelete, vacuum
the FSM to expose those pages to concurrent activity.
Try to avoid redundant FSM vacuum at vacuumcleanup.
---
src/backend/access/nbtree/nbtree.c | 22 ++++++++++++++++++++--
src/backend/access/spgist/spgvacuum.c | 18 ++++++++++++++++--
2 files changed, 36 insertions(+), 4 deletions(-)
diff --git a/src/backend/access/nbtree/nbtree.c b/src/backend/access/nbtree/nbtree.c
index 8158508..d673b88 100644
--- a/src/backend/access/nbtree/nbtree.c
+++ b/src/backend/access/nbtree/nbtree.c
@@ -798,6 +798,12 @@ btbulkdelete(IndexVacuumInfo *info, IndexBulkDeleteResult *stats,
cycleid = _bt_start_vacuum(rel);
btvacuumscan(info, stats, callback, callback_state, cycleid);
+
+ if (stats->pages_deleted > 0)
+ {
+ /* vacuum the FSM to expose deleted pages, if any */
+ IndexFreeSpaceMapVacuum(info->index);
+ }
}
PG_END_ENSURE_ERROR_CLEANUP(_bt_end_vacuum_callback, PointerGetDatum(rel));
_bt_end_vacuum(rel);
@@ -813,6 +819,8 @@ btbulkdelete(IndexVacuumInfo *info, IndexBulkDeleteResult *stats,
IndexBulkDeleteResult *
btvacuumcleanup(IndexVacuumInfo *info, IndexBulkDeleteResult *stats)
{
+ bool needs_fsm_vacuum;
+
/* No-op in ANALYZE ONLY mode */
if (info->analyze_only)
return stats;
@@ -825,15 +833,25 @@ btvacuumcleanup(IndexVacuumInfo *info, IndexBulkDeleteResult *stats)
*
* Since we aren't going to actually delete any leaf items, there's no
* need to go through all the vacuum-cycle-ID pushups.
+ *
+ * If there was a btbulkdelete call, it will vacuum the FSM too if it
+ * deleted any pages, so we can skip our FSM vacuum in that case only.
*/
if (stats == NULL)
{
stats = (IndexBulkDeleteResult *) palloc0(sizeof(IndexBulkDeleteResult));
btvacuumscan(info, stats, NULL, NULL, 0);
+
+ needs_fsm_vacuum = true;
}
+ else
+ needs_fsm_vacuum = (stats->pages_deleted == 0);
- /* Finally, vacuum the FSM */
- IndexFreeSpaceMapVacuum(info->index);
+ if (needs_fsm_vacuum)
+ {
+ /* Finally, vacuum the FSM */
+ IndexFreeSpaceMapVacuum(info->index);
+ }
/*
* It's quite possible for us to be fooled by concurrent page splits into
diff --git a/src/backend/access/spgist/spgvacuum.c b/src/backend/access/spgist/spgvacuum.c
index 72839cb..e9ed3fb 100644
--- a/src/backend/access/spgist/spgvacuum.c
+++ b/src/backend/access/spgist/spgvacuum.c
@@ -898,6 +898,12 @@ spgbulkdelete(IndexVacuumInfo *info, IndexBulkDeleteResult *stats,
spgvacuumscan(&bds);
+ if (stats->pages_deleted > 0)
+ {
+ /* vacuum the FSM to expose deleted pages, if any */
+ IndexFreeSpaceMapVacuum(info->index);
+ }
+
return stats;
}
@@ -918,6 +924,7 @@ spgvacuumcleanup(IndexVacuumInfo *info, IndexBulkDeleteResult *stats)
{
Relation index = info->index;
spgBulkDeleteState bds;
+ bool needs_fsm_vacuum;
/* No-op in ANALYZE ONLY mode */
if (info->analyze_only)
@@ -938,10 +945,17 @@ spgvacuumcleanup(IndexVacuumInfo *info, IndexBulkDeleteResult *stats)
bds.callback_state = NULL;
spgvacuumscan(&bds);
+
+ needs_fsm_vacuum = true;
}
+ else
+ needs_fsm_vacuum = stats->pages_deleted == 0;
- /* Finally, vacuum the FSM */
- IndexFreeSpaceMapVacuum(index);
+ if (needs_fsm_vacuum)
+ {
+ /* Finally, vacuum the FSM */
+ IndexFreeSpaceMapVacuum(index);
+ }
/*
* It's quite possible for us to be fooled by concurrent tuple moves into
--
1.8.4.5
