Hello. I'd like to make a humble comment. At Thu, 15 Feb 2018 19:31:47 +0900, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote in <8906c861-ea47-caee-c860-eff8d7e1d...@lab.ntt.co.jp> > Added to CF here: https://commitfest.postgresql.org/17/1520/
The reorganization adds/removes header files to/from .[ch] files. That can easily leave useless includes and they're hardly noticed. Following files touched in this patch have such useless includes after this patch. On the other hand, naive decision of this kind of cleanup can lead to curruption. [1] So, I don't insisit that the all of the following *should* amended, especially for rel.h. [1] https://www.postgresql.org/message-id/6748.1518711...@sss.pgh.pa.us ==== nodeModifyTable.c: > +#include "rewrite/rewriteManip.h" rewriteManip.h is changed to include rel.h so rel.h is no longer need to be included in the file. (It is also included in lmgr.h so it was needless since before this patch, though.) ==== hba.c: > +#include "catalog/objectaddress.h" objectaddress.h includes acl.h so acl.h is no longer useful. ==== joinrels.c: > +#include "utils/partcache.h" partcache.h includes lsyscache.h. ==== prepunion.c: > +#include "utils/partcache.h" partcache.h includes lsyscache.h and partcache.h is included in rel.h. So partcache.h and lsyscache.h are not required. ==== utility.c: > +#include "utils/rel.h" rel.h includes xlog.h (and xlog.h includes fd.h). The last two are removable. ==== partcache.c: parsenodes.h is included from some other files. rel.h is included from rewriteManip.h. partcache.h is included from rel.h As the result, parsenodes.h, rel.h, partcache.h are not required. ==== relcache.c: > +#include "utils/partcache.h" lsyscache.h is included by partcache.h. ==== rel.h: > +#include "utils/partcache.h" partcache.h includes fmgr.h and relcache.h so the last two are no longer useful. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
