On 09/02/18 06:24, Andrew Dunstan wrote: > On Mon, Feb 5, 2018 at 7:49 AM, Andrew Dunstan > <andrew.duns...@2ndquadrant.com> wrote: >> On Mon, Feb 5, 2018 at 7:19 AM, Thomas Munro >> <thomas.mu...@enterprisedb.com> wrote: >>> On Fri, Jan 26, 2018 at 1:23 PM, Andrew Dunstan >>> <andrew.duns...@2ndquadrant.com> wrote: >>>> Yeah, thanks. revised patch attached >>> >>> FYI the identity regression test started failing recently with this >>> patch applied (maybe due to commit >>> 533c5d8bddf0feb1785b3da17c0d17feeaac76d8?) >>> >> >> Thanks. Probably the same bug Tomas Vondra found a few days ago. I'm on it. >> > > > Here's a version that fixes the above issue and also the issue with > VACUUM that Tomas Vondra reported. I'm still working on the issue with > aggregates that Tomas also reported. >
I see the patch does not update the ALTER TABLE docs section which discusses table rewrites and it seems like it should. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
