On Wed, Feb 7, 2018 at 7:57 PM, Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > Claudio Freire wrote: > >> - vacuum test on its own parallel group > > Hmm, this solution is not very friendly to the goal of reducing test > runtime, particularly since the new test creates a nontrivial-sized > table. Maybe we can find a better alternative. Can we use some wait > logic instead? Maybe something like grab a snapshot of running VXIDs > and loop waiting until they're all gone before doing the vacuum?
I'm not sure there's any alternative. I did some tests and any active snapshot on any other table, not necessarily on the one being vacuumed, distorted the test. And it makes sense, since that snapshot makes those deleted tuples unvacuumable. Waiting as you say would be akin to what the patch does by putting vacuum on its own parallel group. I'm guessing all tests write something to the database, so all tests will create a snapshot. Maybe if there were read-only tests, those might be safe to include in vacuum's parallel group, but otherwise I don't see any alternative. > Also, I don't understand why pg_relation_size() is not a better solution > to determining the table size compared to explain. I was told pg_relation_size can return stale information. I didn't check, I took that at face value.
