On 2018-02-06 15:43:29 -0500, Tom Lane wrote: > Andres Freund <and...@anarazel.de> writes: > > We've several callers to load_external_function() that do not use the > > returned value as a PGFunction. I'd vote for changing the return type to > > void * and have fmgr.c cast it to PGFunction after verifying the > > function's magic. > > void* isn't necessarily compatible with function pointers --- there are > platforms where they're physically different widths, though possibly > you'd never get PG to run on such hardware anyway.
Fair point. Although we're relying on dlsym like infrastructure, which returns just a void *. > However, given that a cast is going to be necessary anyway, it seems > like this is mostly useless churn... Ok, can live with that too. Just though it was a bit weird... Greetings, Andres Freund
