On 01/23/2018 09:05 PM, Alvaro Herrera wrote: > This stuff sounds pretty nice. However, have a look at this report: > > https://codecov.io/gh/postgresql-cfbot/postgresql/commit/2aa632dae3066900e15d2d42a4aad811dec11f08 > > it seems to me that the new code is not tested at all. Shouldn't you > add a few more tests? >
I have a hard time reading the report, but you're right I haven't added any tests for the new opclasses (bloom and minmax_multi). I agree that's something that needs to be addressed. > I think 0004 should apply to unpatched master (except for the parts > that concern files not in master); sounds like a good candidate for > first apply. Then 0001, which seems mostly just refactoring. 0002 and > 0003 are the really interesting ones (minus the code removed by > 0004). > That sounds like a reasonable plan. I'll reorder the patch series along those lines in the next few days. regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
