On 19/01/18 12:41, Marco Nenciarini wrote: > Hi Peter, > > Il 18/01/18 17:30, Peter Eisentraut ha scritto: >> On 1/17/18 11:33, Petr Jelinek wrote: >>>> P.S: I'm struggling to understand why we have two possible values of >>>> session_replication_role settings that behave identically (origin and >>>> local). I'm unable to see any difference according to the code or the >>>> documentation, so I'm wondering if we should document that they are the >>>> same. >>>> >>> It's for use by 3rd party tools (afaik both londiste and slony use it) >>> to differentiate between replicated and not replicated changes. >> >> I have committed some documentation updates and tests to cover this a >> bit better. >> > > Thanks, the documentation is a lot clearer now. > > This superseded the documentation change that was in the patch, so I've > removed it from the v3 version. >
Now that we have tests for this, I think it would be good idea to expand them to cover the new behavior of TRUNCATE in this patch. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
