On Thu, Jan 18, 2018 at 2:05 PM, Peter Geoghegan <p...@bowt.ie> wrote: > Review of your patch: > > * SerializedReindexState could use some comments. At least a one liner > stating its basic purpose.
Added a comment. > * The "System index reindexing support" comment block could do with a > passing acknowledgement of the fact that this is serialized for > parallel workers. Done. > * Maybe the "Serialize reindex state" comment within > InitializeParallelDSM() should instead say something like "Serialize > indexes-pending-reindex state". That would require corresponding changes in a bunch of other places, possibly including the function names. I think it's better to keep the function names shorter and the comments matching the function names, so I did not make this change. > Other than that, looks good to me. It's a simple patch with a clear purpose. Committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
