On Wed, Jan 17, 2018 at 12:31 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Probably not very. It'd be nice to have it done by the next minor > releases, ie before 5-Feb ... but given that these bugs are years > old, missing that deadline would not be catastrophic.
Got it. >> I'm not sure whether or not we should also apply this >> still-to-be-written 9.5 patch to 9.4 and 9.3, since those versions >> don't have grouping sets, and so cannot crash. ISTM that we should >> leave them alone, since tuplesort has had this problem forever. > > +1. If the problem isn't known to be reproducible in those branches, > the risk of adding new bugs seems to outweigh any benefit. You could make the same objection to changing tuplesort_getdatum() outside of the master branch, though. I think that going back further than that for the (arguably independent) tuplesort_getdatum() subset fix might still be a good idea. I wonder where you stand on this. -- Peter Geoghegan
