Peter Eisentraut wrote: > Subject: [PATCH 1/2] Update portal-related memory context names and API > > Rename PortalMemory to TopPortalContext, to avoid confusion with > PortalContext and align naming with similar top-level memory contexts. > > Rename PortalData's "heap" field to portalContext. The "heap" naming > seems quite antiquated and confusing. Also get rid of the > PortalGetHeapMemory() macro and access the field directly, which we do > for other portal fields, so this abstraction doesn't buy anything.
This one looks good to me. I was long confused by that "heap" terminology. > Subject: [PATCH 2/2] Remove PortalGetQueryDesc() > > After having gotten rid of PortalGetHeapMemory(), there seems little > reason to keep one Portal access macro around that offers no actual > abstraction and isn't consistently used anyway. This macro does look quite pointless. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
