On Sun, Dec 31, 2017 at 09:52:27PM -0800, Noah Misch wrote: > Since now() is transaction_timestamp(), $recovery_time precedes or equals > $lsn3, and this didn't close the race. Using clock_timestamp() here would > work, as does using separate transactions like recovery-test-fixes.patch did. > I'll shortly push a fix for this and a similar ordering problem in the > standby_5 test, which first appeared subsequent to this thread.
As recovery_target_inclusive is true by default, my conclusion on the matter, which was something that my tests on hamster, the now-dead buildfarm animal seemed to confirm, is that just getting a timestamp at least the value of the LSN from the same transaction was enough to fix all the failures. And hamster was really slow. I can follow why logically your patch makes sense, so I agree that this is sane. Have you spotted failures from the buildfarm? This is hard to spot from any people which just have access to what the buildfarm UI offers, so any reference to failures on this thread would be welcome. -- Michael
signature.asc
Description: PGP signature
